Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 11348211: Remove wrong assert in string validator. (Closed)

Created:
8 years, 1 month ago by erikcorry
Modified:
8 years, 1 month ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove wrong assert in string validator. Out of range unicode escapes are handled with a regular error message, an assert is not needed. R=karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/string_validator.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
erikcorry
8 years, 1 month ago (2012-11-23 14:14:13 UTC) #1
karlklose
8 years, 1 month ago (2012-11-23 14:17:16 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698