Issue 11348129: Add JSNumber, JSInt and JSDouble for the new interceptor scheme.

Issue 11348129: Add JSNumber, JSInt and JSDouble for the new interceptor scheme. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
ahe, karlklose

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add JSNumber, JSInt and JSDouble for the new interceptor scheme. Committed: https://code.google.com/p/dart/source/detail?r=15085

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -190 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/enqueue.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	3 chunks	+38 lines, -18 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/interceptors.dart	View		4 chunks	+3 lines, -171 lines	0 comments	Download
A	sdk/lib/_internal/compiler/implementation/lib/js_number.dart	View		1 chunk	+124 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_string.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/11348129/diff/2001/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/11348129/diff/2001/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode763 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:763: cls.forEachMember((ClassElement klass, Element member) { 'klass' -> 'element'?

8 years, 1 month ago (2012-11-19 14:32:46 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-19 14:33:32 UTC) #3

Thanks Karl

https://codereview.chromium.org/11348129/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/11348129/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:763:
cls.forEachMember((ClassElement klass, Element member) {
On 2012/11/19 14:32:46, karlklose wrote:
> 'klass' -> 'element'?

element looks too generic. How about currentClass?

Expand Messages | Collapse Messages