Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 11348127: Make HTTP server close sockets when closed in idle state (Closed)

Created:
8 years, 1 month ago by Søren Gjesse
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make HTTP server close sockets when closed in idle state If a connection was in the idle state and the socket was closed by the client the server did close the connection. This caused the server to quickly run out of resources. There was a state check missing after a state change. Added a COSING state as well and a way to get the number of connections if various states. R=ager@google.com, ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15069

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -4 lines) Patch
M sdk/lib/io/http.dart View 1 chunk +35 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 7 chunks +30 lines, -4 lines 0 comments Download
M tests/standalone/io/http_shutdown_test.dart View 2 chunks +63 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 1 month ago (2012-11-19 09:26:54 UTC) #1
Mads Ager (google)
8 years, 1 month ago (2012-11-19 10:56:57 UTC) #2
LGTM

This seems related to: dartbug.com/4652?

https://codereview.chromium.org/11348127/diff/1/tests/standalone/io/http_shut...
File tests/standalone/io/http_shutdown_test.dart (right):

https://codereview.chromium.org/11348127/diff/1/tests/standalone/io/http_shut...
tests/standalone/io/http_shutdown_test.dart:134: // close the client and wait
for the server to loose all active
loose -> lose

Powered by Google App Engine
This is Rietveld 408576698