Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 11348111: Adding support for accessing attributes in alternate namespaces. (Closed)

Created:
8 years, 1 month ago by blois
Modified:
8 years ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding support for accessing attributes in alternate namespaces. BUG=5395 Committed: https://code.google.com/p/dart/source/detail?r=15347

Patch Set 1 #

Patch Set 2 : Adding missing file. #

Patch Set 3 : Minor cleanup #

Total comments: 2

Patch Set 4 : Incorporating review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+769 lines, -501 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 8 chunks +248 lines, -165 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 8 chunks +254 lines, -165 lines 0 comments Download
M sdk/lib/html/scripts/htmlrenamer.py View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
A sdk/lib/html/src/AttributeMap.dart View 1 2 3 1 chunk +223 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Element.darttemplate View 1 2 3 2 chunks +8 lines, -165 lines 0 comments Download
M tests/html/element_test.dart View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
Hey Jacob- I think this is along the lines of what you were suggesting a ...
8 years, 1 month ago (2012-11-16 23:51:59 UTC) #1
blois
On 2012/11/16 23:51:59, blois wrote: > Hey Jacob- > I think this is along the ...
8 years, 1 month ago (2012-11-20 19:22:37 UTC) #2
Jacob
lgtm I'm not crazy about the name getNamespacedAttributes but at least it is a bit ...
8 years, 1 month ago (2012-11-21 01:05:40 UTC) #3
blois
On 2012/11/21 01:05:40, Jacob wrote: > lgtm > > I'm not crazy about the name ...
8 years ago (2012-11-26 21:48:43 UTC) #4
blois
8 years ago (2012-11-26 21:48:50 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/11348111/diff/9/sdk/lib/html/src/AttributeMap...
File sdk/lib/html/src/AttributeMap.dart (right):

https://codereview.chromium.org/11348111/diff/9/sdk/lib/html/src/AttributeMap...
sdk/lib/html/src/AttributeMap.dart:76: * Wrapper to expose Element.attributes as
a typed map.
On 2012/11/21 01:05:40, Jacob wrote:
> Element.attributes ==> [Element.attributes]
> ?

Done.

Powered by Google App Engine
This is Rietveld 408576698