Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 11348088: Changed: TestCase.output -> TestCase.commandOutputs[] (Closed)

Created:
8 years, 1 month ago by kustermann
Modified:
8 years, 1 month ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Changed: TestCase.output -> TestCase.commandOutputs[] Currently the TestCase has exactly one TestOutput. This worked until now, since we were only interested in the output of the last command. This change introduces one CommandOutput for each command which has been run. Doing so enables us to fetch output (stdin,stderr) information as well as exitCode ... for all commands. See also 11293278. Committed: https://code.google.com/p/dart/source/detail?r=15006

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -106 lines) Patch
M tests/standalone/io/test_runner_exit_code_script.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_progress.dart View 1 9 chunks +20 lines, -19 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 19 chunks +168 lines, -81 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
PTAL. Since the old issue '11293278' was closed, so I created a new one. A ...
8 years, 1 month ago (2012-11-16 10:08:58 UTC) #1
ricow1
lgtm https://codereview.chromium.org/11348088/diff/1/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): https://codereview.chromium.org/11348088/diff/1/tools/testing/dart/test_progress.dart#newcode78 tools/testing/dart/test_progress.dart:78: _tests.sort((a, b) { add a todo here, we ...
8 years, 1 month ago (2012-11-16 10:36:56 UTC) #2
Bill Hesse
LGTM.
8 years, 1 month ago (2012-11-16 10:37:33 UTC) #3
kustermann
8 years, 1 month ago (2012-11-16 11:14:25 UTC) #4
https://codereview.chromium.org/11348088/diff/1/tools/testing/dart/test_progr...
File tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/11348088/diff/1/tools/testing/dart/test_progr...
tools/testing/dart/test_progress.dart:78: _tests.sort((a, b) {
On 2012/11/16 10:36:56, ricow1 wrote:
> add a todo here, we should take all the commands into acount

Done.

Powered by Google App Engine
This is Rietveld 408576698