Issue 11348067: Fix operator handling.

Issue 11348067: Fix operator handling. (Closed)

Created:
8 years, 1 month ago by polux

Modified:
8 years ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix operator handling. Committed: https://code.google.com/p/dart/source/detail?r=15524

Patch Set 2 : Handle []= properly #

Total comments: 8

Patch Set 3 : Address karl's comments. #

Patch Set 4 : Apply style remarks to the rest the file. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -71 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 2 3	3 chunks	+17 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View	1 2 3	7 chunks	+56 lines, -54 lines	0 comments	Download
M	tests/compiler/dart2js/cpa_inference_test.dart	View	1 2 3	4 chunks	+84 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

polux

This CL uses https://chromiumcodereview.appspot.com/11365150/ as a diffbase.

8 years, 1 month ago (2012-11-15 14:24:47 UTC) #1

polux

On 2012/11/15 14:24:47, polux wrote: > This CL uses https://chromiumcodereview.appspot.com/11365150/ as a diffbase. I hadn't ...

8 years, 1 month ago (2012-11-15 17:06:57 UTC) #2

karlklose

LGTM. https://codereview.chromium.org/11348067/diff/1004/tests/compiler/dart2js/cpa_inference_test.dart File tests/compiler/dart2js/cpa_inference_test.dart (right): https://codereview.chromium.org/11348067/diff/1004/tests/compiler/dart2js/cpa_inference_test.dart#newcode656 tests/compiler/dart2js/cpa_inference_test.dart:656: // fieldInitialization(). fieldInitialization() -> testFieldInitialization? (also below) https://codereview.chromium.org/11348067/diff/1004/tests/compiler/dart2js/cpa_inference_test.dart#newcode669 ...

8 years ago (2012-11-28 08:24:07 UTC) #3

polux

8 years ago (2012-11-29 14:18:39 UTC) #4

https://codereview.chromium.org/11348067/diff/1004/tests/compiler/dart2js/cpa...
File tests/compiler/dart2js/cpa_inference_test.dart (right):

https://codereview.chromium.org/11348067/diff/1004/tests/compiler/dart2js/cpa...
tests/compiler/dart2js/cpa_inference_test.dart:656: // fieldInitialization().
On 2012/11/28 08:24:07, karlklose wrote:
> fieldInitialization() -> testFieldInitialization? (also below)

Done.

https://codereview.chromium.org/11348067/diff/1004/tests/compiler/dart2js/cpa...
tests/compiler/dart2js/cpa_inference_test.dart:669: var x3 = 1; x3 += 42;
On 2012/11/28 08:24:07, karlklose wrote:
> Perhaps these statements should all have their own line.

Done.

https://codereview.chromium.org/11348067/diff/1004/tests/compiler/dart2js/cpa...
tests/compiler/dart2js/cpa_inference_test.dart:720: testDisequality() {
On 2012/11/28 08:24:07, karlklose wrote:
> 'Disequality' -> 'Inequality'.

In automated theorem proving, disequalities are inequalities of the form != only
(i.e. excluding <, <=, ...). However, a google search taught me it's not used
very much outside of that field.

Done.

https://codereview.chromium.org/11348067/diff/1004/tests/compiler/dart2js/cpa...
tests/compiler/dart2js/cpa_inference_test.dart:740: // TODO(polux): the
following result should be {null, string}, see
On 2012/11/28 08:24:07, karlklose wrote:
> {null, string} -> [:[null, string]:]

Done. Is [: :] used in non dartdoc comments too?

Expand Messages | Collapse Messages