Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11348061: Always clobber all of the output directory (Closed)

Created:
8 years, 1 month ago by ricow1
Modified:
8 years, 1 month ago
Reviewers:
ahe, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Always clobber all of the output directory Committed: https://code.google.com/p/dart/source/detail?r=14953

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M tools/clean_output_directory.py View 1 1 chunk +2 lines, -8 lines 3 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
8 years, 1 month ago (2012-11-15 10:37:05 UTC) #1
Ivan Posva
LGTM -ip
8 years, 1 month ago (2012-11-15 10:38:48 UTC) #2
ahe
LGTM with the suggested changes. https://codereview.chromium.org/11348061/diff/3001/tools/clean_output_directory.py File tools/clean_output_directory.py (right): https://codereview.chromium.org/11348061/diff/3001/tools/clean_output_directory.py#newcode17 tools/clean_output_directory.py:17: result.add_option("-m", "--mode", This option ...
8 years, 1 month ago (2012-11-15 11:42:21 UTC) #3
ahe
Well, you can defer removing options if that is easier.
8 years, 1 month ago (2012-11-15 11:42:50 UTC) #4
ricow1
8 years, 1 month ago (2012-11-15 11:46:00 UTC) #5 
On 2012/11/15 11:42:50, ahe wrote:
> Well, you can defer removing options if that is easier.

I will do that, since I also need to update the buildbot scripts to not pass
them - filed http://dartbug.com/6734

Powered by Google App Engine
This is Rietveld 408576698