Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 11348037: A method or accessor with empty body is implicitly abstract. (Closed)

Created:
8 years, 1 month ago by ahe
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org, karlklose
Visibility:
Public.

Description

A method or accessor with empty body is implicitly abstract. Committed: https://code.google.com/p/dart/source/detail?r=14320

Patch Set 1 #

Patch Set 2 : Changes to make unit tests pass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -24 lines) Patch
M dart/lib/compiler/implementation/elements/elements.dart View 3 chunks +12 lines, -1 line 0 comments Download
M dart/lib/compiler/implementation/js_backend/emitter.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/listener.dart View 1 chunk +5 lines, -1 line 0 comments Download
M dart/lib/compiler/implementation/ssa/builder.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
M dart/lib/compiler/implementation/tree/nodes.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M dart/tests/co19/co19-dart2js.status View 2 chunks +6 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js/patch_test.dart View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
8 years, 1 month ago (2012-10-30 16:01:43 UTC) #1
ngeoffray
LGTM!
8 years, 1 month ago (2012-10-30 16:04:12 UTC) #2
ahe
8 years, 1 month ago (2012-10-30 16:05:07 UTC) #3
Johnni Winther
lgtm
8 years, 1 month ago (2012-10-30 19:14:32 UTC) #4
ahe
PTAL, minor tweaks to handle unit tests.
8 years, 1 month ago (2012-10-31 09:03:27 UTC) #5
ngeoffray
8 years, 1 month ago (2012-10-31 09:05:31 UTC) #6
Still LGTM

Powered by Google App Engine
This is Rietveld 408576698