Issue 11348036: Alignments for the ClassMirror interface.

Issue 11348036: Alignments for the ClassMirror interface. (Closed)

Created:
8 years, 1 month ago by Johnni Winther

Modified:
8 years, 1 month ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org, Andrei Mouravski, turnidge

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Alignments for the ClassMirror interface. Committed: https://code.google.com/p/dart/source/detail?r=14282

Patch Set 2 : Updated cf. comments #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -103 lines)			Patch
M	pkg/dartdoc/lib/dartdoc.dart	View		5 chunks	+10 lines, -10 lines	0 comments	Download
M	pkg/dartdoc/lib/mirrors.dart	View		4 chunks	+18 lines, -6 lines	0 comments	Download
M	pkg/dartdoc/lib/mirrors_util.dart	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart	View	1	11 chunks	+40 lines, -36 lines	0 comments	Download
M	tests/compiler/dart2js/mirrors_test.dart	View		20 chunks	+34 lines, -46 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/11348036/diff/1/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right): https://codereview.chromium.org/11348036/diff/1/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart#newcode1077 pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:1077: List<TypeVariableMirror> get typeVariables => originalDeclaration.typeVariables; Long line. https://codereview.chromium.org/11348036/diff/1/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart#newcode1080 ...

8 years, 1 month ago (2012-10-30 14:05:12 UTC) #2

Johnni Winther

https://codereview.chromium.org/11348036/diff/1/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right): https://codereview.chromium.org/11348036/diff/1/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart#newcode1077 pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:1077: List<TypeVariableMirror> get typeVariables => originalDeclaration.typeVariables; On 2012/10/30 14:05:12, kasperl ...

8 years, 1 month ago (2012-10-30 14:25:39 UTC) #3

ahe

8 years, 1 month ago (2012-10-30 14:35:46 UTC) #4

LGTM

https://codereview.chromium.org/11348036/diff/1/pkg/dartdoc/lib/src/mirrors/d...
File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right):

https://codereview.chromium.org/11348036/diff/1/pkg/dartdoc/lib/src/mirrors/d...
pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:1039: Map<String, MemberMirror>
get declaredMembers => originalDeclaration.declaredMembers;
Long line.

https://codereview.chromium.org/11348036/diff/1/pkg/dartdoc/lib/src/mirrors/d...
pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:1167: List<TypeVariableMirror>
get typeVariables => originalDeclaration.typeVariables;
Long line.

Expand Messages | Collapse Messages