Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 11348026: - GrowableArray::RemoveLast returns the value being removed (Closed)

Created:
8 years, 1 month ago by Ivan Posva
Modified:
8 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- GrowableArray::RemoveLast returns the value being removed to avoid having to call Last() followed by RemoveLast(). Committed: https://code.google.com/p/dart/source/detail?r=14237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M vm/flow_graph.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M vm/flow_graph_allocator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M vm/flow_graph_optimizer.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M vm/growable_array.h View 1 chunk +3 lines, -1 line 0 comments Download
M vm/parser.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M vm/scavenger.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ivan Posva
8 years, 1 month ago (2012-10-30 00:17:57 UTC) #1
siva
8 years, 1 month ago (2012-10-30 00:24:27 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698