Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1134753007: dart2js cps: Stack trace should be obtained from raw exception value. (Closed)

Created:
5 years, 7 months ago by asgerf
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Stack trace should be obtained from raw exception value. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/28484b2c6fd83979f2f1946043ffc6fde981c254

Patch Set 1 #

Patch Set 2 : Status file #

Patch Set 3 : Status files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/unsugar.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 7 months ago (2015-05-19 10:54:09 UTC) #2
Kevin Millikin (Google)
LGTM.
5 years, 7 months ago (2015-05-20 07:53:39 UTC) #3
asgerf
5 years, 7 months ago (2015-05-20 11:44:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
28484b2c6fd83979f2f1946043ffc6fde981c254 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698