Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 11347049: Add flag --always_cleared_ic_data, which forces a cleared ICData to be emitted with each IC call (i… (Closed)

Created:
8 years, 1 month ago by srdjan
Modified:
8 years, 1 month ago
Reviewers:
regis
CC:
reviews_dartlang.org, Kevin Millikin (Google)
Visibility:
Public.

Description

Add flag --always_cleared_ic_data, which forces a cleared ICData to be emitted with each IC call (instead of propagating the ICData from unoptimized to optimized code). This addresses Kevin's concern that propagating the ICData may hurt performance when inlining methods as the IC calls of inlined methods may not need all classes as the unoptimized code. Currently running with cleared ICData slows dart2js by > 2%, probably because the ICData has to be repopulated by optimized code through calls to runtime. Adding the flag for experimenting as we work on inlining strategies and megamorphic calls. Committed: https://code.google.com/p/dart/source/detail?r=14367

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 chunks +10 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
8 years, 1 month ago (2012-10-30 23:18:59 UTC) #1
regis
LGTM However, the name "always_cleared_ic_data" sounds confusing to me, as it does not contain a ...
8 years, 1 month ago (2012-10-31 00:24:28 UTC) #2
srdjan
8 years, 1 month ago (2012-10-31 19:49:15 UTC) #3
On 2012/10/31 00:24:28, regis wrote:
> LGTM
> 
> However, the name "always_cleared_ic_data" sounds confusing to me, as it does
> not contain a verb.
> 
> How about --propagate_ic_data with the reverse default value and meaning?

Renamed to propagate_ic_data

Powered by Google App Engine
This is Rietveld 408576698