Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1134583005: Remove the core library stubbing infrastructure. (Closed)

Created:
5 years, 7 months ago by nweiz
Modified:
5 years, 7 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove the core library stubbing infrastructure. This hasn't been used in a long time. It's just clutter now. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/e7a1c3c58576f08988e3b5c062b4d809dc06a108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -991 lines) Patch
M create_sdk.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/pkg.status View 2 chunks +0 lines, -2 lines 0 comments Download
D pkg/stub_core_library/README.md View 1 chunk +0 lines, -6 lines 0 comments Download
D pkg/stub_core_library/bin/stub_core_library.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D pkg/stub_core_library/lib/src/utils.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/stub_core_library/lib/stub_core_library.dart View 1 chunk +0 lines, -391 lines 0 comments Download
D pkg/stub_core_library/pubspec.yaml View 1 chunk +0 lines, -6 lines 0 comments Download
D pkg/stub_core_library/test/stub_test.dart View 1 chunk +0 lines, -428 lines 0 comments Download
M tools/create_sdk.py View 1 chunk +0 lines, -3 lines 0 comments Download
M utils/pub/pub.gyp View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
Peter, can you make sure I didn't break the Gyp infrasturcute with this somehow?
5 years, 7 months ago (2015-05-14 22:16:53 UTC) #2
ahe
lgtm
5 years, 7 months ago (2015-05-18 10:54:01 UTC) #3
nweiz
5 years, 7 months ago (2015-05-18 19:42:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e7a1c3c58576f08988e3b5c062b4d809dc06a108 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698