Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 113453005: Add stack chain support to pub. (Closed)

Created:
7 years ago by nweiz
Modified:
7 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add stack chain support to pub. Specifically, when run with "--trace" or "--verbose", pub will capture its stack chains and report them along with errors. Otherwise it should behave identically to before. R=rnystrom@google.com BUG=8842 Committed: https://code.google.com/p/dart/source/detail?r=31176

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -95 lines) Patch
M sdk/lib/_internal/pub/bin/pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/server.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command.dart View 2 chunks +27 lines, -26 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/lish.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/uploader.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/dart.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/io.dart View 9 chunks +22 lines, -19 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/log.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/version_queue.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source.dart View 2 chunks +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/git.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/hosted.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/path.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/utils.dart View 3 chunks +32 lines, -4 lines 2 comments Download
M sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/directory.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/lib.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/license.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/name.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/version_solver_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
7 years ago (2013-12-16 21:53:40 UTC) #1
Bob Nystrom
If I'm adding some random piece of functionality in pub that uses asynchrony, how do ...
7 years ago (2013-12-17 00:18:03 UTC) #2
nweiz
The rule of thumb is to wrap [Chain.track] around any Future created by a dart: ...
7 years ago (2013-12-17 00:23:04 UTC) #3
Bob Nystrom
lgtm
7 years ago (2013-12-17 00:24:10 UTC) #4
nweiz
7 years ago (2013-12-17 00:26:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r31176 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698