Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 11345027: Do error propagation for decoder errors in string stream. (Closed)

Created:
8 years, 1 month ago by ricow1
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do error propagation for decoder errors in string stream. Currently only the ascii decoder will throw errors. Committed: https://code.google.com/p/dart/source/detail?r=14331

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M lib/io/string_stream.dart View 1 2 5 chunks +17 lines, -3 lines 0 comments Download
M tests/standalone/io/string_stream_test.dart View 1 2 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
8 years, 1 month ago (2012-10-30 11:46:08 UTC) #1
Søren Gjesse
How about a test?
8 years, 1 month ago (2012-10-30 11:58:53 UTC) #2
ricow1
On 2012/10/30 11:58:53, Søren Gjesse wrote: > How about a test? Added test
8 years, 1 month ago (2012-10-30 12:24:29 UTC) #3
Søren Gjesse
lgtm
8 years, 1 month ago (2012-10-30 13:36:05 UTC) #4
ricow1
8 years, 1 month ago (2012-10-30 14:24:15 UTC) #5
On 2012/10/30 13:36:05, Søren Gjesse wrote:
> lgtm

Rebased to new location of string_stream

Powered by Google App Engine
This is Rietveld 408576698