Issue 11345025: Use the encoding parameter for writeString on RandomAccessFile objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11345025: Use the encoding parameter for writeString on RandomAccessFile objects. (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use the encoding parameter for writeString on RandomAccessFile objects. R=sgjesse@google.com BUG=dartbug.com/6392 Committed: https://code.google.com/p/dart/source/detail?r=14268

Patch Set 2 : Address comments. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -71 lines)			Patch
M	lib/io/file_impl.dart	View	1	2 chunks	+15 lines, -23 lines	0 comments	Download
M	runtime/bin/builtin_natives.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/file.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/bin/file.cc	View	1	3 chunks	+0 lines, -43 lines	0 comments	Download
M	runtime/bin/file_patch.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/standalone/io/file_test.dart	View		2 chunks	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

https://codereview.chromium.org/11345025/diff/1/runtime/bin/file_impl.dart File runtime/bin/file_impl.dart (left): https://codereview.chromium.org/11345025/diff/1/runtime/bin/file_impl.dart#oldcode909 runtime/bin/file_impl.dart:909: request[0] = _WRITE_STRING_REQUEST; Shouldn't we fully remove the write ...

8 years, 1 month ago (2012-10-30 10:24:31 UTC) #2

Mads Ager (google)

PTAL Fixed error handling with incorrect encoding param. Removed unused native implemantations. https://codereview.chromium.org/11345025/diff/1/runtime/bin/file_impl.dart File runtime/bin/file_impl.dart ...

8 years, 1 month ago (2012-10-30 11:34:05 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 11345025: Use the encoding parameter for writeString on RandomAccessFile objects. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages