Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 11343059: Configure git explicitly when committing. (Closed)

Created:
8 years, 1 month ago by Bob Nystrom
Modified:
8 years, 1 month ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Configure git explicitly when committing. Committed: https://code.google.com/p/dart/source/detail?r=14314

Patch Set 1 #

Total comments: 2

Patch Set 2 : Typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -22 lines) Patch
M utils/pub/io.dart View 1 3 chunks +21 lines, -12 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 2 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
This patch is exactly like: https://codereview.chromium.org/11276042/ except that it also specifies the GIT_AUTHOR fields. From ...
8 years, 1 month ago (2012-10-30 23:17:58 UTC) #1
nweiz
lgtm https://codereview.chromium.org/11343059/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/11343059/diff/1/utils/pub/io.dart#newcode478 utils/pub/io.dart:478: /// The spawned process will inherit its parents ...
8 years, 1 month ago (2012-10-30 23:29:59 UTC) #2
Bob Nystrom
8 years, 1 month ago (2012-10-30 23:31:42 UTC) #3
https://codereview.chromium.org/11343059/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/11343059/diff/1/utils/pub/io.dart#newcode478
utils/pub/io.dart:478: /// The spawned process will inherit its parents
environment variables. If
On 2012/10/30 23:29:59, nweiz wrote:
> "parents" -> "parent's"

Done.

Powered by Google App Engine
This is Rietveld 408576698