Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 11343047: Disable process PATH tests on windows. (Closed)

Created:
8 years, 1 month ago by Bob Nystrom
Modified:
8 years, 1 month ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, Mads Ager (google)
Visibility:
Public.

Description

Disable process PATH tests on windows. Investigating now. Committed: https://code.google.com/p/dart/source/detail?r=14302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/standalone/standalone.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
8 years, 1 month ago (2012-10-30 18:30:01 UTC) #1
Bob Nystrom
TBR.
8 years, 1 month ago (2012-10-30 18:30:12 UTC) #2
Emily Fortuna
lgtm. curious, though.
8 years, 1 month ago (2012-10-30 18:42:29 UTC) #3
Emily Fortuna
Oh, I know exactly why these are failing (well, from a superficial and cursory look ...
8 years, 1 month ago (2012-10-30 18:47:04 UTC) #4
Bob Nystrom
8 years, 1 month ago (2012-10-30 19:32:07 UTC) #5
On 2012/10/30 18:47:04, Emily Fortuna wrote:
> Oh, I know exactly why these are failing (well, from a superficial and cursory
> look at the context...), basic environment variables are by default available
> when we call processes in WIndows (aka you can't test commands in cmd to
ensure
> they'll work in Dart).

I think the issue might be different here?

What's funny is that these tests are testing a fix for a bug that Windows
doesn't actually have. But I figured the test should run on Windows anyway.

I believe the exact problem here is that I'm just spawning cmd.exe. And
(guessing) because it does have stdin wired up, it thinks its interactive, so it
never exits. I've got a patch coming that runs cmd.exe with some code to execute
so that it runs that and quits.

Powered by Google App Engine
This is Rietveld 408576698