Issue 11343046: Fix equality instruction to switch from checked (polymorphic) to megamorphic state. This helps da…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11343046: Fix equality instruction to switch from checked (polymorphic) to megamorphic state. This helps da… (Closed)

Created:
8 years, 1 month ago by srdjan

Modified:
8 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix equality instruction to switch from checked (polymorphic) to megamorphic state. This helps dart2js as it eliminates excessive deoptimizations (probeForAdding runs now in optimized mode) -> 5% improvement. Committed: https://code.google.com/p/dart/source/detail?r=14309

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -11 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	2 chunks	+8 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages