Disallow 'dynamic' as type parameter name

Disallow 'dynamic' as type parameter name

Fixes issue 2492
Committed: https://code.google.com/p/dart/source/detail?r=14296

[hausner, 2012-10-30 16:45:24]

Tiny fix for type parameter names.

[regis, 2012-10-30 16:53:10]

LGTM

http://codereview.chromium.org/11343044/diff/1004/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/11343044/diff/1004/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:6587: String* Parser::ExpectClassIdentifier(const char*
msg) {
Nitpicking: the name ExpectClassIdentifier is not optimal, since dynamic is a
class as well. ExpectClassDefinitionIdentifier would be better.

[hausner, 2012-10-30 17:44:20]

http://codereview.chromium.org/11343044/diff/1004/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/11343044/diff/1004/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:6587: String* Parser::ExpectClassIdentifier(const char*
msg) {
On 2012/10/30 16:53:10, regis wrote:
> Nitpicking: the name ExpectClassIdentifier is not optimal, since dynamic is a
> class as well. ExpectClassDefinitionIdentifier would be better.

Changed to ExpectUserDefinedTypeIdentifier as discussed offline.