Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 11343033: Fix type annotation in _FileBase._exceptionFromResponse (Closed)

Created:
8 years, 1 month ago by Jennifer Messerly
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix type annotation in _FileBase._exceptionFromResponse ArgumentError is not a subtype of Exception, which leads to confusing errors in checked mode: Expected future to complete successfully, but it failed with type 'ArgumentError' is not a subtype of type 'Exception' of 'function result'. Stack trace: #0 _FileBase._exceptionFromResponse (dart:io:1032:48) #1 _RandomAccessFile.writeString.<anonymous closure> (dart:io:1491:37) #2 _FutureImpl.transform.<anonymous closure> (bootstrap:855:37) Committed: https://code.google.com/p/dart/source/detail?r=14243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/file_impl.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Jennifer Messerly
Figured that sending a patch was more useful than opening a bug :) If there's ...
8 years, 1 month ago (2012-10-30 04:36:54 UTC) #1
Mads Ager (google)
8 years, 1 month ago (2012-10-30 05:45:09 UTC) #2
LGTM! Thanks. I have this exact change pending in a larger changelist to use
patching for dart:io but I might not be able to land that today.

Powered by Google App Engine
This is Rietveld 408576698