Issue 11342039: LibraryMirror interface updated to match dart:mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11342039: LibraryMirror interface updated to match dart:mirrors. (Closed)

Created:
8 years, 1 month ago by Johnni Winther

Modified:
8 years, 1 month ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org, turnidge

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

LibraryMirror interface updated to match dart:mirrors. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14276

Patch Set 2 : Updated cf. comment #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -39 lines)			Patch
M	pkg/dartdoc/lib/dartdoc.dart	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/dartdoc/lib/mirrors.dart	View		1 chunk	+27 lines, -4 lines	0 comments	Download
M	pkg/dartdoc/lib/mirrors_util.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart	View	1	3 chunks	+31 lines, -11 lines	0 comments	Download
M	tests/compiler/dart2js/mirrors_test.dart	View		5 chunks	+18 lines, -15 lines	0 comments	Download
M	utils/apidoc/html_diff.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/11342039/diff/1/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right): https://codereview.chromium.org/11342039/diff/1/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart#newcode487 pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:487: Map<String, ClassMirror> _types; Want to rename this to ...

8 years, 1 month ago (2012-10-30 12:20:17 UTC) #2

Johnni Winther

8 years, 1 month ago (2012-10-30 13:34:28 UTC) #3

https://codereview.chromium.org/11342039/diff/1/pkg/dartdoc/lib/src/mirrors/d...
File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right):

https://codereview.chromium.org/11342039/diff/1/pkg/dartdoc/lib/src/mirrors/d...
pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:487: Map<String, ClassMirror>
_types;
On 2012/10/30 12:20:17, kasperl wrote:
> Want to rename this to _classes too?

Done.

Expand Messages | Collapse Messages

Issue 11342039: LibraryMirror interface updated to match dart:mirrors. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Updated cf. comment #

Messages