Unify evaluation of annotations with evaluation of other constants.

Unify evaluation of annotations with evaluation of other constants.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45713

[Paul Berry, 2015-05-11 18:31:47]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-05-11 18:43:32]

LGTM

https://codereview.chromium.org/1134133002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/constant.dart (right):

https://codereview.chromium.org/1134133002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/constant.dart:1236: return;
This sounds like a problem. Should we be logging the condition?

[Paul Berry, 2015-05-11 19:24:51]

https://codereview.chromium.org/1134133002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/constant.dart (right):

https://codereview.chromium.org/1134133002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/constant.dart:1236: return;
On 2015/05/11 18:43:32, Brian Wilkerson wrote:
> This sounds like a problem. Should we be logging the condition?

Actually, it's not a problem.  There are two situations where constant values
are computed prior to the execution of the ConstantValueComputer: 1. Constants
associated with enum members are computed by EnumMemberBuilder.  2. Constants
associated with other libraries (which aren't in the library cycle) will already
have been computed, but they will be in the dependency graph anyway.

The latter situation will go away once we are in the new element model.  Once
that happens, it will probably be reasonable to add an assertion to make sure
this only happens for enum members.  I've added a TODO comment to that effect.

[Paul Berry, 2015-05-11 19:35:46]

Committed patchset #1 (id:1) manually as 45713 (presubmit successful).