dart2js cps: Introduce GetStatic/SetStatic.

dart2js cps: Introduce GetStatic/SetStatic.

The GetStatic is used for reading static fields and tearing off
static methods.

Invoking a static getter/setter (not from a field) is still an
InvokeStatic, which IMO is the way it should remain.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45735

Reverted: https://code.google.com/p/dart/source/detail?r=45737

Committed: https://code.google.com/p/dart/source/detail?r=45738

[asgerf, 2015-05-11 12:31:09]

asgerf@google.com changed reviewers:
+ karlklose@google.com

[asgerf, 2015-05-11 12:31:10]

https://codereview.chromium.org/1134063002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (left):

https://codereview.chromium.org/1134063002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:292: 
This is just general clean-up since the issue has been fixed.

[karlklose, 2015-05-11 13:10:47]

LGTM.

https://codereview.chromium.org/1134063002/diff/20001/pkg/compiler/lib/src/da...
File pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart (right):

https://codereview.chromium.org/1134063002/diff/20001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart:974: return new
Identifier(node.element.name)..element = node.element;
Not (only) your code: Could we add an optional argument to the constructor
instead of this pattern? Is the element ever changed?

[asgerf, 2015-05-11 13:16:57]

https://codereview.chromium.org/1134063002/diff/20001/pkg/compiler/lib/src/da...
File pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart (right):

https://codereview.chromium.org/1134063002/diff/20001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart:974: return new
Identifier(node.element.name)..element = node.element;
On 2015/05/11 13:10:46, karlklose wrote:
> Not (only) your code: Could we add an optional argument to the constructor
> instead of this pattern? Is the element ever changed?

This file and the backend AST will be deleted soon anyway.

Originally, the element was supposed to go away when we could replace the old
dart2dart backend. That's why it was tacked on like that.

[asgerf, 2015-05-12 13:36:29]

Committed patchset #7 (id:120001) manually as 45735 (presubmit successful).

[asgerf, 2015-05-12 14:20:24]

Committed patchset #9 (id:140001) manually as 45738 (presubmit successful).