Issue 11340044: FieldMirror => VariableMirror

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11340044: FieldMirror => VariableMirror (Closed)

Created:
8 years, 1 month ago by Johnni Winther

Modified:
8 years, 1 month ago

Reviewers:
ahe, Andrei Mouravski, kasperl

CC:
reviews_dartlang.org, turnidge, Andrei Mouravski

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

FieldMirror => VariableMirror + member access methods Committed: https://code.google.com/p/dart/source/detail?r=14317

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -75 lines)			Patch
M	pkg/dartdoc/lib/dartdoc.dart	View	9 chunks	+10 lines, -10 lines	0 comments	Download
M	pkg/dartdoc/lib/mirrors.dart	View	4 chunks	+14 lines, -2 lines	0 comments	Download
M	pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart	View	11 chunks	+56 lines, -59 lines	1 comment	Download
M	tests/compiler/dart2js/mirrors_test.dart	View	3 chunks	+18 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 1 month ago (2012-10-31 08:20:07 UTC) #4

LGTM

http://codereview.chromium.org/11340044/diff/1/pkg/dartdoc/lib/src/mirrors/da...
File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right):

http://codereview.chromium.org/11340044/diff/1/pkg/dartdoc/lib/src/mirrors/da...
pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:497: return new
AsFilteredImmutableMap<String, MemberMirror, MethodMirror>(
This code is really hard to read. Generally, you can assume your code is wrong
if you have more than one type argument.

Expand Messages | Collapse Messages