Issue 5847. Parse incomplete function expression without body

Issue 5847. Parse incomplete function expression without body
http://code.google.com/p/dart/issues/detail?id=5847


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=14305

[Brian Wilkerson, 2012-10-30 13:49:35]

https://codereview.chromium.org/11340033/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://codereview.chromium.org/11340033/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/parser/DartParser.java:4373: boolean
hasTwoIdentifiersComma = peek(0) == Token.IDENTIFIER && peek(1) ==
Token.IDENTIFIER
This is not sufficient for the general case. A type name can consist of "id.id"
as well as "id" and can have type arguments.

[scheglov, 2012-10-30 19:23:51]

https://codereview.chromium.org/11340033/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://codereview.chromium.org/11340033/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/parser/DartParser.java:4373: boolean
hasTwoIdentifiersComma = peek(0) == Token.IDENTIFIER && peek(1) ==
Token.IDENTIFIER
On 2012/10/30 13:49:35, Brian Wilkerson wrote:
> This is not sufficient for the general case. A type name can consist of
"id.id"
> as well as "id" and can have type arguments.

Well, I don't know if we should support here every possible case.
Adding "id.id" is pretty easy.

I've added also type arguments, but this may be too much already.

[Brian Wilkerson, 2012-10-30 19:45:23]

LGTM

https://codereview.chromium.org/11340033/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://codereview.chromium.org/11340033/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/parser/DartParser.java:4373: boolean
hasTwoIdentifiersComma = peek(0) == Token.IDENTIFIER && peek(1) ==
Token.IDENTIFIER
> Well, I don't know if we should support here every possible case.

You're right that it isn't critical to be precise here, but I didn't think it
would be all that hard to recognize a larger set of cases.

https://codereview.chromium.org/11340033/diff/5001/compiler/java/com/google/d...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://codereview.chromium.org/11340033/diff/5001/compiler/java/com/google/d...
compiler/java/com/google/dart/compiler/parser/DartParser.java:4405: private int
looksLikeTypeAnnotation(int offset) {
This looks like skipTypeName(int), except that skipTypeName is more precise. If
you don't want to delete this method right now, please add a comment, or
deprecate it, so that we won't add more uses of it.

[scheglov, 2012-10-30 20:07:31]

https://codereview.chromium.org/11340033/diff/5001/compiler/java/com/google/d...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://codereview.chromium.org/11340033/diff/5001/compiler/java/com/google/d...
compiler/java/com/google/dart/compiler/parser/DartParser.java:4405: private int
looksLikeTypeAnnotation(int offset) {
On 2012/10/30 19:45:23, Brian Wilkerson wrote:
> This looks like skipTypeName(int), except that skipTypeName is more precise.
If
> you don't want to delete this method right now, please add a comment, or
> deprecate it, so that we won't add more uses of it.

Fixed.
Thank you!