Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133983002: Move isolate tests to lib/isolate. (Closed)

Created:
5 years, 7 months ago by floitsch
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Move isolate tests to lib/isolate. Moves most tests that require dart:isolate to the isolate-directory in the tests section. Also enables the string_from_environment_default_value_test which didn't have "_test" in its name. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=45701

Patch Set 1 #

Patch Set 2 : A few more moves. #

Patch Set 3 : Merge with master #

Patch Set 4 : Fix merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -310 lines) Patch
D tests/corelib/bool_from_environment_default_value_test.dart View 1 1 chunk +0 lines, -22 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 3 3 chunks +0 lines, -5 lines 0 comments Download
D tests/corelib/int_from_environment_default_value_test.dart View 1 1 chunk +0 lines, -21 lines 0 comments Download
D tests/corelib/string_from_environment_default_value.dart View 1 1 chunk +0 lines, -21 lines 0 comments Download
A + tests/isolate/bool_from_environment_default_value_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/isolate/deferred_in_isolate_app.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/isolate/deferred_in_isolate_lib.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/isolate/deferred_in_isolate_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/isolate/enum_const_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/isolate/int_from_environment_default_value_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 3 7 chunks +15 lines, -1 line 0 comments Download
A + tests/isolate/string_from_environment_default_value_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/isolate/timer_isolate_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/isolate/typed_message_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/language/deferred_in_isolate_app.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language/deferred_in_isolate_lib.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/language/deferred_in_isolate_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/language/enum_const_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
D tests/language/typed_message_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/lib/async/deferred/deferred_in_isolate_lib.dart View 1 chunk +0 lines, -1 line 0 comments Download
D tests/lib/async/deferred/deferred_in_isolate_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/lib/async/deferred/deferred_library.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M tests/lib/async/future_constructor_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/async/stream_first_where_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/async/stream_last_where_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/async/stream_single_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/async/stream_single_to_multi_subscriber_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/async/timer_cancel_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
D tests/lib/async/timer_isolate_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
M tests/lib/lib.status View 1 2 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 7 months ago (2015-05-09 06:18:19 UTC) #2
Lasse Reichstein Nielsen
lgtm
5 years, 7 months ago (2015-05-09 09:27:13 UTC) #3
floitsch
5 years, 7 months ago (2015-05-11 18:00:28 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 45701 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698