Cleanup run on DartDoc from Dart Editor.

Cleanup run on DartDoc from Dart Editor.

Committed: https://code.google.com/p/dart/source/detail?r=14345

[Andrei Mouravski, 2012-10-30 22:07:26]

Please make sure I didn't do anything stupid.

Thanks!

[gram, 2012-10-30 22:30:04]

lgtm apart from the one parameter issue.

https://codereview.chromium.org/11339056/diff/1/pkg/dartdoc/lib/dartdoc.dart
File pkg/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/11339056/diff/1/pkg/dartdoc/lib/dartdoc.dart#...
pkg/dartdoc/lib/dartdoc.dart:1554: String a(String href, String contents,
{String css}) {
Why use a named parameter here? Usually you would use named parameters where
there are several optional parameters and you don't want to make the user have
to provide all n-1 preceding ones just to specify the nth. I see no benefit here
to not leaving this as just optional.

[Andrei Mouravski, 2012-10-31 15:08:00]

Thanks! Submitting.

https://codereview.chromium.org/11339056/diff/1/pkg/dartdoc/lib/dartdoc.dart
File pkg/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/11339056/diff/1/pkg/dartdoc/lib/dartdoc.dart#...
pkg/dartdoc/lib/dartdoc.dart:1554: String a(String href, String contents,
{String css}) {
On 2012/10/30 22:30:04, gram wrote:
> Why use a named parameter here? Usually you would use named parameters where
> there are several optional parameters and you don't want to make the user have
> to provide all n-1 preceding ones just to specify the nth. I see no benefit
here
> to not leaving this as just optional.

Done.