Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 11339051: Use command on Windows that ends quickly. (Closed)

Created:
8 years, 1 month ago by Bob Nystrom
Modified:
8 years, 1 month ago
Reviewers:
ahe, Emily Fortuna
CC:
reviews_dartlang.org, Mads Ager (google), ahe
Visibility:
Public.

Description

Use command on Windows that ends quickly. Committed: https://code.google.com/p/dart/source/detail?r=14311

Patch Set 1 #

Patch Set 2 : Re-enable skipped test. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M tests/standalone/io/process_path_environment_test.dart View 1 chunk +7 lines, -2 lines 1 comment Download
M tests/standalone/io/process_path_test.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
OK, trying this again. Just running "cmd.exe" doesn't exit, but this seems to work better. ...
8 years, 1 month ago (2012-10-30 19:33:31 UTC) #1
Emily Fortuna
ah, makes sense. My previous guess was without looking at your tests too closely, just ...
8 years, 1 month ago (2012-10-30 19:42:53 UTC) #2
ahe
https://codereview.chromium.org/11339051/diff/2001/tests/standalone/io/process_path_environment_test.dart File tests/standalone/io/process_path_environment_test.dart (right): https://codereview.chromium.org/11339051/diff/2001/tests/standalone/io/process_path_environment_test.dart#newcode5 tests/standalone/io/process_path_environment_test.dart:5: // Test that the executable is looked up on ...
8 years, 1 month ago (2012-10-31 06:43:35 UTC) #3
Bob Nystrom
8 years, 1 month ago (2012-11-01 20:59:01 UTC) #4
On 2012/10/31 06:43:35, ahe wrote:
>
https://codereview.chromium.org/11339051/diff/2001/tests/standalone/io/proces...
> File tests/standalone/io/process_path_environment_test.dart (right):
> 
>
https://codereview.chromium.org/11339051/diff/2001/tests/standalone/io/proces...
> tests/standalone/io/process_path_environment_test.dart:5: // Test that the
> executable is looked up on the user's PATH when spawning a
> I don't understand this test. Did it fail before CL 11260048 landed?

Well, this test didn't exist before that patch. But, yes, if it had, it would
have been failing the entire time. That patch was specifically to fix that fact.

Powered by Google App Engine
This is Rietveld 408576698