Issue 1133903003: Forward instantiation type to LocalsHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1133903003: Forward instantiation type to LocalsHandler. (Closed)

Created:
5 years, 7 months ago by Johnni Winther

Modified:
5 years, 7 months ago

Reviewers:
zarah

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Forward instantiation type to LocalsHandler. BUG= R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=45693

Patch Set 2 : Updated cf. comment #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -24 lines)			Patch
	M	pkg/compiler/lib/src/ssa/builder.dart	View	1	20 chunks	+61 lines, -24 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zarah

LGTM! https://codereview.chromium.org/1133903003/diff/1/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/1133903003/diff/1/pkg/compiler/lib/src/ssa/builder.dart#newcode217 pkg/compiler/lib/src/ssa/builder.dart:217: /// [instanceType] is not used it contains type ...

5 years, 7 months ago (2015-05-11 13:12:55 UTC) #3

Johnni Winther

Committed patchset #2 (id:20001) manually as 45693 (presubmit successful).

5 years, 7 months ago (2015-05-11 15:45:49 UTC) #4

Johnni Winther

5 years, 7 months ago (2015-05-11 15:56:05 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1133903003/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1133903003/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:217: /// [instanceType] is not used it
contains type variables, since these might
On 2015/05/11 13:12:55, zarah wrote:
> insert 'when/if' between 'used' and 'it'.

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1133903003: Forward instantiation type to LocalsHandler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Updated cf. comment #

Messages