Issue 11339027: - Avoid going into BigInteger domain for most of the Random state calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11339027: - Avoid going into BigInteger domain for most of the Random state calculation. (Closed)

Created:
8 years, 1 month ago by Ivan Posva

Modified:
8 years, 1 month ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Avoid going into BigInteger domain for most of the Random state calculation. - Makes it much easier to intrinsify the operation. Committed: https://code.google.com/p/dart/source/detail?r=14235

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	lib/math_patch.dart	View		2 chunks	+9 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

srdjan

8 years, 1 month ago (2012-10-30 00:16:57 UTC) #2

LGTM

https://codereview.chromium.org/11339027/diff/1/lib/math_patch.dart
File lib/math_patch.dart (right):

https://codereview.chromium.org/11339027/diff/1/lib/math_patch.dart#newcode39
lib/math_patch.dart:39: _Random._internal(state)
you can type this int.

Expand Messages | Collapse Messages