Do not emit is dynamic/Object checks.

Do not emit is dynamic/Object checks.

R=podivilov@chromium.org

Committed: https://code.google.com/p/dart/source/detail?r=14280

[podivilov, 2012-10-30 13:28:00]

https://codereview.chromium.org/11338033/diff/1/lib/html/scripts/systemnative.py
File lib/html/scripts/systemnative.py (right):

https://codereview.chromium.org/11338033/diff/1/lib/html/scripts/systemnative...
lib/html/scripts/systemnative.py:476: checks = filter(lambda e: e != 'true',
checks)
This looks sketchy. Please don't add those checks in the list.

[Anton Muhin, 2012-10-30 13:29:35]

https://codereview.chromium.org/11338033/diff/1/lib/html/scripts/systemnative.py
File lib/html/scripts/systemnative.py (right):

https://codereview.chromium.org/11338033/diff/1/lib/html/scripts/systemnative...
lib/html/scripts/systemnative.py:476: checks = filter(lambda e: e != 'true',
checks)
On 2012/10/30 13:28:00, podivilov wrote:
> This looks sketchy. Please don't add those checks in the list.

a) that's the easier for the current solution when we populate the list with ?!
checks and it mirrors what we do for dart2js.

If you insist, I can rewrite both though.  Would probably prefer to do that as a
separate CL to ease checking if it's changed dispatcher or not.

[podivilov, 2012-10-30 13:32:58]

https://codereview.chromium.org/11338033/diff/1/lib/html/scripts/systemnative.py
File lib/html/scripts/systemnative.py (right):

https://codereview.chromium.org/11338033/diff/1/lib/html/scripts/systemnative...
lib/html/scripts/systemnative.py:476: checks = filter(lambda e: e != 'true',
checks)
On 2012/10/30 13:29:35, Anton Muhin wrote:
> On 2012/10/30 13:28:00, podivilov wrote:
> > This looks sketchy. Please don't add those checks in the list.
> 
> a) that's the easier for the current solution when we populate the list with
?!
> checks and it mirrors what we do for dart2js.

If I remember correctly, dart2js code was copy-pasted from here. And where is b?
:)

> 
> If you insist, I can rewrite both though.  Would probably prefer to do that as
a
> separate CL to ease checking if it's changed dispatcher or not.

Yes, please.

[podivilov, 2012-10-30 13:56:32]

lgtm