Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133793002: Remove unneeded flag declaratiosn (enable_type_checks, enable_asserts). (Closed)

Created:
5 years, 7 months ago by srdjan
Modified:
5 years, 7 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove unneeded flag declaratiosn (enable_type_checks, enable_asserts). R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=45647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M runtime/lib/object.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/ast.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 7 months ago (2015-05-08 11:32:40 UTC) #2
hausner
LGTM.
5 years, 7 months ago (2015-05-08 16:12:39 UTC) #3
srdjan
5 years, 7 months ago (2015-05-08 16:49:25 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as r45647 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698