Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133713006: Deprecate 'dart:profiler' and move functionality to 'dart:developer' (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
Søren Gjesse, kevmoo
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deprecate 'dart:profiler' and move functionality to 'dart:developer' R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/6e42aec4f64cf356dde7bad9426e07e0ea5b58d5

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -287 lines) Patch
M runtime/lib/developer_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/profiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D runtime/lib/profiler_sources.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
M runtime/vm/bootstrap.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 chunk +6 lines, -5 lines 0 comments Download
M runtime/vm/method_recognizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm.gypi View 6 chunks +0 lines, -45 lines 0 comments Download
M sdk/lib/developer/developer.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/developer/developer_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + sdk/lib/developer/profiler.dart View 1 chunk +1 line, -4 lines 0 comments Download
M sdk/lib/profiler/profiler.dart View 1 1 chunk +8 lines, -194 lines 0 comments Download
M tests/compiler/dart2js/incremental/compile_all.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/profiler/metrics_num_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/profiler/metrics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/profiler/user_tags_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Cutch
5 years, 7 months ago (2015-05-15 01:29:00 UTC) #2
kevmoo
DBC https://codereview.chromium.org/1133713006/diff/1/sdk/lib/profiler/profiler.dart File sdk/lib/profiler/profiler.dart (right): https://codereview.chromium.org/1133713006/diff/1/sdk/lib/profiler/profiler.dart#newcode5 sdk/lib/profiler/profiler.dart:5: /// NOTE: This library has been deprecated for ...
5 years, 7 months ago (2015-05-15 02:17:33 UTC) #4
Søren Gjesse
lgtm https://codereview.chromium.org/1133713006/diff/1/runtime/lib/profiler.cc File runtime/lib/profiler.cc (right): https://codereview.chromium.org/1133713006/diff/1/runtime/lib/profiler.cc#newcode18 runtime/lib/profiler.cc:18: // Native implementations for the dart:developer library. Maybe ...
5 years, 7 months ago (2015-05-18 10:08:31 UTC) #5
Cutch
https://codereview.chromium.org/1133713006/diff/1/runtime/lib/profiler.cc File runtime/lib/profiler.cc (right): https://codereview.chromium.org/1133713006/diff/1/runtime/lib/profiler.cc#newcode18 runtime/lib/profiler.cc:18: // Native implementations for the dart:developer library. On 2015/05/18 ...
5 years, 7 months ago (2015-05-18 17:57:33 UTC) #6
Cutch
5 years, 7 months ago (2015-05-18 17:58:07 UTC) #7
Cutch
Committed patchset #3 (id:40001) manually as 6e42aec4f64cf356dde7bad9426e07e0ea5b58d5 (presubmit successful).
5 years, 7 months ago (2015-05-18 18:31:31 UTC) #8
kevmoo
5 years, 6 months ago (2015-06-23 21:26:53 UTC) #9
Message was sent while issue was closed. 
On 2015/05/18 18:31:31, Cutch wrote:
> Committed patchset #3 (id:40001) manually as
> 6e42aec4f64cf356dde7bad9426e07e0ea5b58d5 (presubmit successful).

Make sure you update CHANGELOG.md when you change dart:* APIs. Thanks.

Powered by Google App Engine
This is Rietveld 408576698