Issue 1133703003: Add LIBRARY_ERRORS result.

Issue 1133703003: Add LIBRARY_ERRORS result. (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Add LIBRARY_ERRORS result. This result will work as a top-level target for Dart work manager. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45668

Patch Set 2 : Replace LIBRARY_ERRORS with the LIBRARY_ERRORS_READY flag. #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -4 lines)			Patch
M	pkg/analyzer/lib/src/plugin/engine_plugin.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	1	3 chunks	+54 lines, -4 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	1	2 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

I understand what this does, but not how you're going to use it. I guess ...

5 years, 7 months ago (2015-05-08 22:15:20 UTC) #2

scheglov

https://codereview.chromium.org/1133703003/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1133703003/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode2296 pkg/analyzer/lib/src/task/dart.dart:2296: outputs[LIBRARY_ERRORS] = AnalysisError.mergeLists(errorLists); On 2015/05/08 22:15:20, Brian Wilkerson wrote: ...

5 years, 7 months ago (2015-05-08 23:10:55 UTC) #3

scheglov

5 years, 7 months ago (2015-05-08 23:11:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 45668 (presubmit successful).

Expand Messages | Collapse Messages