Make sure to process WebSocket frames when closing a WebSocket

Make sure to process WebSocket frames when closing a WebSocket

On a WebSocket the actual listening on the stream is causing the
processing of inbound frames to start. If the connection is closed
without ever being listened on, then a close frame from the other end
will not be processed.  In this case the timeout of waiting for a
close from the other end will always be hit.

If you are _only_ using the WebSocket connection in one direction it
seems a bit artificial to have to listen on the stream to even process
the close frame.

This change will make sure the stream is listened to when closing a
WebSocket.

This is a breaking change. Before you could close and then
listen. With this change that sequence will throw on the listen. This
is reflected in the changes that was needed for the tests.

R=kustermann@google.com, lrn@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=45679

[kustermann, 2015-05-08 13:21:20]

lgtm with comments

https://codereview.chromium.org/1133673006/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/1133673006/diff/1/sdk/lib/io/websocket_impl.d...
sdk/lib/io/websocket_impl.dart:969: _controller.stream.drain();
This can cause an un-catchable exception. You need to do put a catchError on it.

https://codereview.chromium.org/1133673006/diff/1/tests/standalone/io/web_soc...
File tests/standalone/io/web_socket_test.dart (right):

https://codereview.chromium.org/1133673006/diff/1/tests/standalone/io/web_soc...
tests/standalone/io/web_socket_test.dart:185: });
indentation

https://codereview.chromium.org/1133673006/diff/1/tests/standalone/io/web_soc...
tests/standalone/io/web_socket_test.dart:201: });
indentation

[Søren Gjesse, 2015-05-11 09:33:02]

Committed patchset #2 (id:20001) manually as 45679 (presubmit successful).

[Søren Gjesse, 2015-06-15 07:51:32]

These are old reply comments I have forgot to send.

https://codereview.chromium.org/1133673006/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/1133673006/diff/1/sdk/lib/io/websocket_impl.d...
sdk/lib/io/websocket_impl.dart:969: _controller.stream.drain();
On 2015/05/08 13:21:20, kustermann wrote:
> This can cause an un-catchable exception. You need to do put a catchError on
it.

Thanks. Added catchError which ignored the error.

https://codereview.chromium.org/1133673006/diff/1/tests/standalone/io/web_soc...
File tests/standalone/io/web_socket_test.dart (right):

https://codereview.chromium.org/1133673006/diff/1/tests/standalone/io/web_soc...
tests/standalone/io/web_socket_test.dart:185: });
On 2015/05/08 13:21:20, kustermann wrote:
> indentation

Done.

https://codereview.chromium.org/1133673006/diff/1/tests/standalone/io/web_soc...
tests/standalone/io/web_socket_test.dart:201: });
On 2015/05/08 13:21:20, kustermann wrote:
> indentation

Done.