Eagerly create local var descriptors for artificially created methods (they cannot be regularly par…

Eagerly create local var descriptors for artificially created methods (they cannot be regularly parsed).

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45606

[srdjan, 2015-05-07 16:35:46]

srdjan@google.com changed reviewers:
+ hausner@google.com

[srdjan, 2015-05-07 16:35:47]

Third time is the charm, gell? A cleanup CL (removing the flag) will follow once
all bots are happy.

[hausner, 2015-05-07 16:45:29]

LGTM w/comments

https://codereview.chromium.org/1133633002/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1133633002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1139: ASSERT(var_descs.IsNull());
This would fail for regexp function, right? They have eagerly precomputed var
descriptors.
Either move this assertion to the else branch or move the IsIrregexpFunction()
check to the beginning of this function.

https://codereview.chromium.org/1133633002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1150: UNREACHABLE();
Why is the setjmp needed if there is never an exception?

https://codereview.chromium.org/1133633002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1153: code.set_var_descriptors(var_descs);
ASSERT here that the computed var_descs are not null?

[srdjan, 2015-05-07 18:57:56]

https://codereview.chromium.org/1133633002/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1133633002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1139: ASSERT(var_descs.IsNull());
On 2015/05/07 16:45:29, hausner wrote:
> This would fail for regexp function, right? They have eagerly precomputed var
> descriptors.
> Either move this assertion to the else branch or move the IsIrregexpFunction()
> check to the beginning of this function.

This method should not be called if local var descriptor exists already, only if
GetLocalVarDescriptors determines that one is needed. Converted
IsIrregexpFunction to an assert

https://codereview.chromium.org/1133633002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1150: UNREACHABLE();
On 2015/05/07 16:45:29, hausner wrote:
> Why is the setjmp needed if there is never an exception?

Removed. Was useful for debugging as an error in Parser created a mess. Added
comment.

https://codereview.chromium.org/1133633002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1153: code.set_var_descriptors(var_descs);
On 2015/05/07 16:45:29, hausner wrote:
> ASSERT here that the computed var_descs are not null?

Done.

[srdjan, 2015-05-07 19:04:41]

Committed patchset #3 (id:40001) manually as r45606 (presubmit successful).