Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1133623002: Ensure that nulls aren't added to constant eval dependency graph. (Closed)

Created:
5 years, 7 months ago by Paul Berry
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Ensure that nulls aren't added to constant eval dependency graph. In r45541, I accidentally left out a null check causing nulls to get inserted into the constant evaluation dependency graph. This caused a log message to be printed when running the command-line analyzer, but no test failures. I've inserted the proper null check and added an assert statement so that if the bug recurs it will be caught during testing. BUG=dartbug.com/23407 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 7 months ago (2015-05-07 13:46:56 UTC) #2
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-07 14:20:53 UTC) #3
Paul Berry
5 years, 7 months ago (2015-05-07 14:42:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45594 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698