pkg/test: handle symlinked dart executable

handle symlinked dart executable

R=nweiz@google.com

Committed: https://github.com/dart-lang/test/commit/1eb9d79009a215f492ac990abd3751f3c2868e91

[kevmoo, 2015-05-15 18:19:26]

kevmoo@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2015-05-15 20:04:51]

Add a CHANGELOG entry for this.

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart
File lib/src/util/io.dart (right):

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart#ne...
lib/src/util/io.dart:23: String _sdkDir;
For lazy top-level variables, I like to take advantage of Dart's built-in lazy
initialization and write something like:

final String sdkDir = (() {
  // ...
})();

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart#ne...
lib/src/util/io.dart:26: String get sdkDir {
Add a TODO to get rid of this variable when Platform.sdkPath exists.

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart#ne...
lib/src/util/io.dart:28: // This may fail on Mac if `dart` is run directly from
the PATH environment
What does "run directly from the PATH environment" mean? Also, it seems like a
problem if this can still fail.

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart#ne...
lib/src/util/io.dart:29: // See
https://code.google.com/p/dart/issues/detail?id=21791
What does this issue have to do with it?

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart#ne...
lib/src/util/io.dart:30: var path = new
File(Platform.executable).resolveSymbolicLinksSync();
What if the bin directory is symlinked rather than the executable?

https://codereview.chromium.org/1133603005/diff/20001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1133603005/diff/20001/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.12.2-dev
Just make this 0.12.1+1.

[kevmoo, 2015-05-21 17:46:22]

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart
File lib/src/util/io.dart (right):

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart#ne...
lib/src/util/io.dart:23: String _sdkDir;
On 2015/05/15 20:04:50, nweiz wrote:
> For lazy top-level variables, I like to take advantage of Dart's built-in lazy
> initialization and write something like:
> 
> final String sdkDir = (() {
>   // ...
> })();

Done.

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart#ne...
lib/src/util/io.dart:26: String get sdkDir {
On 2015/05/15 20:04:50, nweiz wrote:
> Add a TODO to get rid of this variable when Platform.sdkPath exists.

Not sure if that's going to happen, given the current discussion.

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart#ne...
lib/src/util/io.dart:28: // This may fail on Mac if `dart` is run directly from
the PATH environment
On 2015/05/15 20:04:50, nweiz wrote:
> What does "run directly from the PATH environment" mean? Also, it seems like a
> problem if this can still fail.

Acknowledged.

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart#ne...
lib/src/util/io.dart:29: // See
https://code.google.com/p/dart/issues/detail?id=21791
On 2015/05/15 20:04:50, nweiz wrote:
> What does this issue have to do with it?

Acknowledged.

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart#ne...
lib/src/util/io.dart:30: var path = new
File(Platform.executable).resolveSymbolicLinksSync();
On 2015/05/15 20:04:50, nweiz wrote:
> What if the bin directory is symlinked rather than the executable?

This still works. resolveSymbolicLinks does the work to walk out of directories
that have been symlinked, too

[nweiz, 2015-05-21 19:06:01]

lgtm

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart
File lib/src/util/io.dart (right):

https://codereview.chromium.org/1133603005/diff/20001/lib/src/util/io.dart#ne...
lib/src/util/io.dart:26: String get sdkDir {
On 2015/05/21 17:46:22, kevmoo wrote:
> On 2015/05/15 20:04:50, nweiz wrote:
> > Add a TODO to get rid of this variable when Platform.sdkPath exists.
> 
> Not sure if that's going to happen, given the current discussion.

A TODO to simplify it when Platform.executable is reliable would be fine, too.
Just make sure to link it to the appropriate issue.

[kevmoo, 2015-06-01 23:59:30]

Committed patchset #4 (id:60001) manually as
1eb9d79009a215f492ac990abd3751f3c2868e91 (presubmit successful).