Issue 11336012: Remove public SocketInputStream and SocketOutputStream clases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11336012: Remove public SocketInputStream and SocketOutputStream clases (Closed)

Created:
8 years, 1 month ago by Søren Gjesse

Modified:
8 years, 1 month ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove public SocketInputStream and SocketOutputStream clases The socket streams only implement the streams interfaces so no explicit classes are needed for these. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14204

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -39 lines)			Patch
M	runtime/bin/io_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/socket_impl.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
D	runtime/bin/socket_stream.dart	View	1 chunk	+0 lines, -25 lines	0 comments	Download
M	runtime/bin/socket_stream_impl.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/io/echo_server_stream_test.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/standalone/io/stream_pipe_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/ddbg.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

8 years, 1 month ago (2012-10-30 06:41:54 UTC) #3

On 2012/10/29 15:03:55, Mads Ager wrote:
> LGTM

This broke dartdoc since it is sourcing in runtime/bin/socket_stream.dart

http://build.chromium.org/p/client.dart/builders/dart2js-chrome-linux/builds/...

Expand Messages | Collapse Messages