Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1133343007: Fix path for dart2js native tests. (Closed)

Created:
5 years, 7 months ago by ricow1
Modified:
5 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix path for dart2js native tests. This seems a bit fragile, I can easily imagine people checkout out into directories not named dart (well, now sdk) TBR=floitsch@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5edbaf31360dc9b2540c2441cac2e80cabb5e1a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
5 years, 7 months ago (2015-05-17 06:45:08 UTC) #1
ricow1
tbr
5 years, 7 months ago (2015-05-17 06:45:28 UTC) #2
ricow1
Committed patchset #1 (id:1) manually as 5edbaf31360dc9b2540c2441cac2e80cabb5e1a4.
5 years, 7 months ago (2015-05-17 06:45:57 UTC) #3
floitsch
5 years, 7 months ago (2015-05-18 13:11:30 UTC) #4
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698