Issue 1133243004: Tool to compute BMU plots from GC logs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1133243004: Tool to compute BMU plots from GC logs. (Closed)

Created:
5 years, 7 months ago by koda

Modified:
5 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Tool to compute BMU plots from GC logs. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45786

Patch Set 6 : #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+214 lines, -0 lines)			Patch
A	runtime/tools/bmu_benchmark_gallery.sh	View		1 chunk	+38 lines, -0 lines	0 comments	Download
A	runtime/tools/verbose_gc_to_bmu.dart	View		1 chunk	+105 lines, -0 lines	0 comments	Download
A	tests/standalone/verbose_gc_to_bmu_test.dart	View	1 2 3 4 5	1 chunk	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/1133243004/diff/60001/tests/standalone/verbose_gc_to_bmu_test.dart File tests/standalone/verbose_gc_to_bmu_test.dart (right): https://codereview.chromium.org/1133243004/diff/60001/tests/standalone/verbose_gc_to_bmu_test.dart#newcode63 tests/standalone/verbose_gc_to_bmu_test.dart:63: if (stdoutLines.length < 200) { Please comment ...

5 years, 7 months ago (2015-05-14 05:06:35 UTC) #2

koda

On 2015/05/14 05:06:35, Ivan Posva wrote: > LGTM -ip > > https://codereview.chromium.org/1133243004/diff/60001/tests/standalone/verbose_gc_to_bmu_test.dart > File tests/standalone/verbose_gc_to_bmu_test.dart ...

5 years, 7 months ago (2015-05-14 16:42:37 UTC) #3

koda

5 years, 7 months ago (2015-05-14 16:43:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #6 (id:100001) manually as r45786 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1133243004: Tool to compute BMU plots from GC logs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Messages