Issue 1133113002: Only build and archive docs on linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1133113002: Only build and archive docs on linux (Closed)

Created:
5 years, 7 months ago by ricow1

Modified:
5 years, 7 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Only build and archive docs on linux TBR=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45688

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/bots/dart_sdk.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 (id:1) manually as 45688 (presubmit successful).

5 years, 7 months ago (2015-05-11 15:08:34 UTC) #2

ricow1

On 2015/05/11 15:18:21, kustermann wrote: > WHY? Because there is no need to do this ...

5 years, 7 months ago (2015-05-11 15:20:07 UTC) #4

ricow1

5 years, 7 months ago (2015-05-11 15:24:27 UTC) #5

Message was sent while issue was closed.

On 2015/05/11 15:20:07, ricow1 wrote:
> On 2015/05/11 15:18:21, kustermann wrote:
> > WHY?
> 
> Because there is no need to do this on top of each other, that will just lead
to
> races, e.g., two bots will archive at the same time to the same "directory"
> 
> This is what we did before as well (it was just hidden somewhere in those
1700+
> lines of python)

Oh, and because I was stupid, follow up to actually exclude the right step:
https://codereview.chromium.org/1135593003/

Expand Messages | Collapse Messages