Issue 1132923002: dart2js: Remove isD8 and isJsShell functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1132923002: dart2js: Remove isD8 and isJsShell functions. (Closed)

Created:
5 years, 7 months ago by floitsch

Modified:
5 years, 7 months ago

Reviewers:
herhut, sra1

CC:
reviews_dartlang.org, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

dart2js: Remove isD8 and isJsShell functions. These functions were used to detect d8 and jsshell. They are not used anymore because of preamble files. R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=45779

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -45 lines)			Patch
M	sdk/lib/_internal/compiler/js_lib/js_helper.dart	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	tests/compiler/dart2js_native/dart2js_native.status	View	2 chunks	+0 lines, -9 lines	0 comments	Download
D	tests/compiler/dart2js_native/only_pass_on_d8_test.dart	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	tests/compiler/dart2js_native/only_pass_on_jsshell_test.dart	View	1 chunk	+0 lines, -12 lines	0 comments	Download

Total messages: 5 (2 generated)

floitsch

5 years, 7 months ago (2015-05-13 20:51:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45779 (presubmit successful).