Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1132783002: Add Accessor, Getter, and Setter elements. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add Accessor, Getter, and Setter elements. + a bit of model polishing BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=45689

Patch Set 1 #

Total comments: 5

Patch Set 2 : Updated cf. comments #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -149 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 2 5 chunks +24 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 2 17 chunks +82 lines, -45 lines 0 comments Download
M pkg/compiler/lib/src/elements/visitor.dart View 3 chunks +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/scanner/class_element_parser.dart View 2 chunks +5 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/scanner/listener.dart View 9 chunks +116 lines, -42 lines 0 comments Download
M pkg/compiler/lib/src/scanner/scannerlib.dart View 2 chunks +5 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Look in elements.dart and listener.dart first.
5 years, 7 months ago (2015-05-08 10:30:59 UTC) #2
sigurdm
LGTM please update CL description with mention of other changes https://codereview.chromium.org/1132783002/diff/1/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (left): https://codereview.chromium.org/1132783002/diff/1/pkg/compiler/lib/src/elements/modelx.dart#oldcode426 ...
5 years, 7 months ago (2015-05-08 11:20:48 UTC) #3
Johnni Winther
https://codereview.chromium.org/1132783002/diff/1/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1132783002/diff/1/pkg/compiler/lib/src/elements/modelx.dart#newcode424 pkg/compiler/lib/src/elements/modelx.dart:424: bool get hasBody => true; On 2015/05/08 11:20:48, sigurdm ...
5 years, 7 months ago (2015-05-11 14:06:59 UTC) #4
Johnni Winther
5 years, 7 months ago (2015-05-11 15:10:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 45689 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698