Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1132673003: Create a new home for Java code generated by analysis server. (Closed)

Created:
5 years, 7 months ago by Paul Berry
Modified:
5 years, 7 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Create a new home for Java code generated by analysis server. This code used to be generated directly into editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated, however now that editor is no longer part of this repository that doesn't work anymore. Fixes the test pkg/analysis_server/tool/spec/check_all_test. R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=45646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9312 lines, -3 lines) Patch
M pkg/analysis_server/tool/spec/codegen_analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 1 chunk +1 line, -2 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java View 1 chunk +520 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/AddContentOverlay.java View 1 chunk +132 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/AnalysisError.java View 1 chunk +199 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/AnalysisErrorFixes.java View 1 chunk +138 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/AnalysisErrorSeverity.java View 1 chunk +32 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/AnalysisErrorType.java View 1 chunk +42 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/AnalysisOptions.java View 1 chunk +258 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/AnalysisService.java View 1 chunk +40 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/AnalysisStatus.java View 1 chunk +136 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/ChangeContentOverlay.java View 1 chunk +142 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/CompletionSuggestion.java View 1 chunk +520 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/CompletionSuggestionKind.java View 1 chunk +64 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/Element.java View 1 chunk +297 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/ElementKind.java View 1 chunk +70 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/ExecutableFile.java View 1 chunk +134 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/ExecutableKind.java View 1 chunk +34 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/ExecutionService.java View 1 chunk +28 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/ExtractLocalVariableFeedback.java View 1 chunk +167 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/ExtractLocalVariableOptions.java View 1 chunk +152 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/ExtractMethodFeedback.java View 1 chunk +272 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/ExtractMethodOptions.java View 1 chunk +261 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/FoldingKind.java View 1 chunk +36 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/FoldingRegion.java View 1 chunk +153 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/HighlightRegion.java View 1 chunk +157 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/HighlightRegionType.java View 1 chunk +102 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/HoverInformation.java View 1 chunk +351 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/InlineLocalVariableFeedback.java View 1 chunk +132 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/InlineMethodFeedback.java View 1 chunk +155 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/InlineMethodOptions.java View 1 chunk +152 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/LinkedEditGroup.java View 1 chunk +165 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/LinkedEditSuggestion.java View 1 chunk +135 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/LinkedEditSuggestionKind.java View 1 chunk +34 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/Location.java View 1 chunk +191 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/MoveFileOptions.java View 1 chunk +120 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/NavigationRegion.java View 1 chunk +177 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/NavigationTarget.java View 1 chunk +220 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/Occurrences.java View 1 chunk +166 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/Outline.java View 1 chunk +207 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/OverriddenMember.java View 1 chunk +134 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/OverrideMember.java View 1 chunk +186 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/Position.java View 1 chunk +134 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/PubStatus.java View 1 chunk +115 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RefactoringFeedback.java View 1 chunk +85 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RefactoringKind.java View 1 chunk +44 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RefactoringMethodParameter.java View 1 chunk +242 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RefactoringMethodParameterKind.java View 1 chunk +32 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RefactoringOptions.java View 1 chunk +85 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RefactoringProblem.java View 1 chunk +159 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RefactoringProblemSeverity.java View 1 chunk +34 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RemoveContentOverlay.java View 1 chunk +113 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RenameFeedback.java View 1 chunk +172 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RenameOptions.java View 1 chunk +120 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RequestError.java View 1 chunk +155 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/RequestErrorCode.java View 1 chunk +136 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/SearchResult.java View 1 chunk +182 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/SearchResultKind.java View 1 chunk +61 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/ServerService.java View 1 chunk +28 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/SourceChange.java View 1 chunk +182 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/SourceEdit.java View 1 chunk +186 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/SourceFileEdit.java View 1 chunk +163 lines, -0 lines 0 comments Download
A pkg/analysis_server/tool/spec/generated/java/types/TypeHierarchyItem.java View 1 chunk +271 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
The added files are all code-generated. The only actual changes are in pkg/analysis_server/tool/spec/codegen_analysis_server.dart and pkg/analysis_server/tool/spec/codegen_java_types.dart.
5 years, 7 months ago (2015-05-08 16:17:07 UTC) #2
danrubel
LGTM. Thanks!
5 years, 7 months ago (2015-05-08 16:24:03 UTC) #3
Paul Berry
5 years, 7 months ago (2015-05-08 16:40:55 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 45646 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698