Issue 1132423002: Implement AnalysisContext.ensureResolvedDartUnits().

Issue 1132423002: Implement AnalysisContext.ensureResolvedDartUnits(). (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Implement AnalysisContext.ensureResolvedDartUnits(). R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45707

Patch Set 1 #

Total comments: 4

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+191 lines, -42 lines)			Patch
M	pkg/analyzer/lib/src/context/context.dart	View	2 chunks	+34 lines, -34 lines	2 comments	Download
M	pkg/analyzer/lib/src/task/dart_work_manager.dart	View	7 chunks	+39 lines, -8 lines	2 comments	Download
M	pkg/analyzer/test/src/context/context_test.dart	View	1 chunk	+84 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_work_manager_test.dart	View	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1132423002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1132423002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode1476 pkg/analyzer/lib/src/context/context.dart:1476: CacheState _getResultState( Should this be moved to AnalysisCache? ...

5 years, 7 months ago (2015-05-11 18:36:49 UTC) #2

scheglov

https://codereview.chromium.org/1132423002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1132423002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode1476 pkg/analyzer/lib/src/context/context.dart:1476: CacheState _getResultState( On 2015/05/11 18:36:49, Brian Wilkerson wrote: > ...

5 years, 7 months ago (2015-05-11 18:46:07 UTC) #3

scheglov

5 years, 7 months ago (2015-05-11 18:49:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45707 (presubmit successful).

Expand Messages | Collapse Messages