Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 113223002: Write a README for the Intl package (Closed)

Created:
7 years ago by Alan Knight
Modified:
7 years ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Write a README for the Intl package BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=31090

Patch Set 1 #

Total comments: 6

Patch Set 2 : Changes from review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -18 lines) Patch
A pkg/intl/README.md View 1 1 chunk +306 lines, -0 lines 0 comments Download
M pkg/intl/lib/intl.dart View 3 chunks +6 lines, -17 lines 0 comments Download
M pkg/intl/test/date_time_format_test_stub.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Alan Knight
7 years ago (2013-12-11 21:01:16 UTC) #1
Emily Fortuna
lgtm. just a typo https://codereview.chromium.org/113223002/diff/1/pkg/intl/README.md File pkg/intl/README.md (right): https://codereview.chromium.org/113223002/diff/1/pkg/intl/README.md#newcode79 pkg/intl/README.md:79: examples. The `name` and `args` ...
7 years ago (2013-12-11 23:15:57 UTC) #2
Alan Knight
https://codereview.chromium.org/113223002/diff/1/pkg/intl/README.md File pkg/intl/README.md (right): https://codereview.chromium.org/113223002/diff/1/pkg/intl/README.md#newcode79 pkg/intl/README.md:79: examples. The `name` and `args` parameters are required, and ...
7 years ago (2013-12-11 23:30:32 UTC) #3
Alan Knight
7 years ago (2013-12-11 23:30:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r31090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698