Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 1132153002: Add Debugger.inspect. 1976 here we come! (Closed)

Created:
5 years, 7 months ago by rmacnak
Modified:
5 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add Debugger.inspect. 1976 here we come! R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45664

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -12 lines) Patch
M runtime/lib/developer.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/lib/developer.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.html View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 4 chunks +6 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/debugger_inspect_test.dart View 1 1 chunk +43 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/service.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/service_event.h View 4 chunks +11 lines, -0 lines 0 comments Download
M runtime/vm/service_event.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/developer_patch.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M sdk/lib/developer/developer.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + tests/lib/developer/inspect_test.dart View 1 2 1 chunk +8 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 7 months ago (2015-05-08 18:25:30 UTC) #2
Cutch
LGTM after: 1) 'dart:debugger' -> 'dart:developer' rebase. 2) A no-op implementation for dart2js. 3) A ...
5 years, 7 months ago (2015-05-08 21:46:12 UTC) #3
rmacnak
On 2015/05/08 21:46:12, Cutch wrote: > LGTM after: > > 1) 'dart:debugger' -> 'dart:developer' rebase. ...
5 years, 7 months ago (2015-05-08 22:18:17 UTC) #4
rmacnak
5 years, 7 months ago (2015-05-08 22:19:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 45664 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698