Issue 113193006: Handle dynamic as type argument.

Issue 113193006: Handle dynamic as type argument. (Closed)

Created:
7 years ago by ahe

Modified:
6 years, 11 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, zarah

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handle dynamic as type argument. BUG=http://dartbug.com/15573 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=31977

Patch Set 2 : Merged with r31967. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2 lines)			Patch
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download
M	dart/tests/lib/lib.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	dart/tests/lib/mirrors/raw_type_test.dart	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/113193006/diff/20001/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/113193006/diff/20001/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode2163 dart/sdk/lib/_internal/lib/js_mirrors.dart:2163: typeArgument is! JsTypeBoundClassMirror) { This assertion is wrong. ...

7 years ago (2013-12-12 09:29:44 UTC) #2

ahe

Thank you, Johnni! https://codereview.chromium.org/113193006/diff/20001/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/113193006/diff/20001/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode2163 dart/sdk/lib/_internal/lib/js_mirrors.dart:2163: typeArgument is! JsTypeBoundClassMirror) { On 2013/12/12 ...

7 years ago (2013-12-12 10:01:50 UTC) #3

Johnni Winther

https://codereview.chromium.org/113193006/diff/20001/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/113193006/diff/20001/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode2163 dart/sdk/lib/_internal/lib/js_mirrors.dart:2163: typeArgument is! JsTypeBoundClassMirror) { On 2013/12/12 10:01:51, ahe wrote: ...

7 years ago (2013-12-12 10:19:52 UTC) #4

ahe

6 years, 11 months ago (2014-01-22 18:02:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r31977 (presubmit successful).

Expand Messages | Collapse Messages